woocommerce evals: don't crash on unknown email charsets in Subject headers - #68
Open
bleonard wants to merge 1 commit into
Open
woocommerce evals: don't crash on unknown email charsets in Subject headers#68bleonard wants to merge 1 commit into
bleonard wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
woocommerce-product-recallverifier failed whole runs with:email.header.decode_headercan report charset labels that are RFC-legal but have no Python codec (e.g.unknown-8bit); callingpart.decode(encoding or 'utf-8')on those raisesLookupError, which fails the entire email check regardless of what the agent actually sent.Body decoding was already hardened against exactly this (
_decode_email_partfalls back to utf-8 witherrors="replace"); the Subject path wasn't.This PR applies the same fallback to Subject decoding in
woocommerce-product-recall, and to the identical pattern inwoocommerce-stock-alert(two sites) andwoocommerce-new-product.