nvidia-market: compare institution names on normalized form in Sheet 4 check - #67
Open
bleonard wants to merge 1 commit into
Open
nvidia-market: compare institution names on normalized form in Sheet 4 check#67bleonard wants to merge 1 commit into
bleonard wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents were scoring 0 on Sheet 4's institution checks while submitting the correct institutions. Groundtruth names are SEC-filing style (
JPMORGAN CHASE & CO,BANK OF AMERICA CORP /DE/,GEODE CAPITAL MANAGEMENT, LLC), while agents write display-case names derived from the same data (JPMorgan Chase & Co.,Bank of America Corp.). The check intersected raw strings, so a real failing run produced:The grader already normalizes shareholder names with
normalize_strfor Sheets 2–3; this PR applies the same normalization to the Sheet 4 intersection, additionally stripping SEC state-of-incorporation markers (/DE/) and a leading "The".Replayed against the failing run's data: the "Continuous Increase" check goes 0 → 2 matches (now passes its ≥1 bar); "Top 5 Most Active" goes 1 → 2 (still under its ≥3 bar — those lists genuinely differ, so the check stays meaningful). Distinct institutions remain distinct under the normalization.