Skip to content

i18n: Add Polish (pl) translation - #374

Merged
hkdb merged 7 commits into
hkdb:v0.3.3-devfrom
aquilapl:i18n/add-polish-language
Aug 6, 2026
Merged

hkdb merged 7 commits into
hkdb:v0.3.3-devfrom
aquilapl:i18n/add-polish-language

Conversation

@aquilapl

@aquilapl aquilapl commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@hkdb

hkdb commented Aug 4, 2026 •

Copy link
Copy Markdown
Owner

Thanks for the Polish translation — the language quality looks great, and the wiring (dateFnsLocale, desktop entry, index.ts) is mostly right. A few things need fixing before this can merge:

  1. metainfo.xml lost required content. Your change deletes the entire release history from 0.1.28 back to 0.1.9, plus the <content_rating>, <supports>, and <requires> blocks — these are required for the Flathub listing. Please reset the file to the one on v0.3.3-dev and re-apply only your xml:lang="pl" additions. Also please revert the zh-TW string change and the extra CASA <p> added to the 0.3.0 release notes — those aren't part of this contribution.
  2. The main pl.json was translated from an older en.json. Compared to frontend/src/lib/i18n/locales/en.json on v0.3.3-dev it's missing 88 keys (e.g. the whole spellcheck section, settings.extensions*, account.customOAuth*, account.authMechanism, contactSource.forceSync*, oauth.writeAccessPicker., oauthMissing.) and carries 175 keys that no longer exist. Please rebase your fork on the latest v0.3.3-dev and sync the file so its keys match en.json 1:1.
  3. Contacts extension locale isn't registered. Add register('pl', () => import('./locales/pl.json')) to extensions/contacts/frontend/i18n/index.ts — without it your extensions/contacts/.../pl.json never loads. (That file itself is complete — nice work.)
  4. Small nits: keep en first in both the register() block and supportedLocales in frontend/src/lib/i18n/index.ts (it's the fallback/default, deliberately listed first), and add a trailing newline to extensions/contacts/frontend/i18n/locales/pl.json.

@hkdb

hkdb commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Thanks! Getting close!

Missing (add after rebasing on latest v0.3.3-dev):

  • settingsGeneral.alwaysShowCheckbox
  • settingsGeneral.alwaysShowCheckboxHelp

Placeholders dropped (must contain the {tokens} from en.json):

  • oauth.writeAccessPicker.description — {provider}, {sourceName}
  • oauth.writeAccessPicker.emptyHeading — {provider}
  • oauth.writeAccessPicker.emptyHint — {provider}
  • oauth.writeAccessPicker.successToast — {name}
  • oauth.writeAccessPicker.failureToast — {message}
  • oauth.writeAccessPicker.loadFailed — {message}
  • contactSource.forceSyncConfirmTitle — {name}
  • contactSource.forceSyncConfirmDescription — {name}

Placeholder that shouldn't be there (en has none):

  • settings.extensionsVersion — remove {version}

Still in English:

  • viewer.pgpExpiredKey
  • viewer.pgpRevokedKey
  • viewer.pgpUnknownKey
  • viewer.smimeExpiredCert
  • viewer.smimeSelfSigned
  • viewer.smimeUnknownSigner
  • viewer.noContent

@hkdb

hkdb commented Aug 6, 2026

Copy link
Copy Markdown
Owner

toast.removedStar is missing.

I also changed the .desktop recently which is causing the branch conflict.

@hkdb

hkdb commented Aug 6, 2026

Copy link
Copy Markdown
Owner

Actually, I am going to use this:

"removedStar": "Usunięto gwiazdkę"

and if it's wrong or needs to be improved, Just do another PR.

I want to merge this in asap so I can release it with v0.3.3. Thanks.

@hkdb
hkdb force-pushed the i18n/add-polish-language branch from 7aabe2b to 8d29b64 Compare August 6, 2026 05:27
@hkdb

hkdb commented Aug 6, 2026

Copy link
Copy Markdown
Owner

Thanks for all the work again! I have put in the fix. Merging it now.

@hkdb
hkdb merged commit 91c1d7c into hkdb:v0.3.3-dev Aug 6, 2026
3 checks passed
@aquilapl
aquilapl deleted the i18n/add-polish-language branch August 6, 2026 05:39
@hkdb hkdb mentioned this pull request Aug 6, 2026
hkdb added a commit that referenced this pull request Aug 6, 2026
* Bump to v0.3.3-dev

* IMAP/SMTP auth fix - #355

* Added digest auth for contacts and calendars - #313

* Update flathub offline build

* Fixed glitch when rapid deleting messages

* Refactored to engine-level serialization

* Improved toast notification logic - #115

* Added states to fix unwanted message list reset - #348

* Improved CalDAV discovery - #363

* Reduce organizer-email error confusion - #363

* Basic CarDAV (Mailfence) support - #366

* Fixed typo in autostart code - #33

* i18n nb fixes (#371)

* NB translations controlled and updated.

→ Main application translation file has been slightly reordered to match EN file to simplify future translations using a diff viewer.

* Indents fix.

* FORCED indents fix. (changing all the editor settings)

* i18n nb translation amendments for (#371) :

- Trailing newline restored on all 3 nb.json files (main, calendar, contacts)
- contacts.edit.urls → "Nettadresser" (plural, matching "URLs")
- Double space removed in settingsGeneral.showMessageListProfilePicsHelp
- Sertfikat → Sertifikat — all 8 occurrences fixed (viewer, toast, dialog, security sections); zero remain

* Added g, G, alt+c, alt+m shortcuts - #351

* alt+g, alt+G

* Backfilled v to contact list

* Message list redesign + swipe gestures - #68 + #70

* Updated what's new

* Commit bdadc7c also fixes #340

* Fixed .desktop - #356 - #367

* Fixed multi-select alt+m and alt+c

* multigetVCards + fetchVCardByGET - #366

* Fixed attachment leak on reply - #381

* i18n: Add Polish (pl) translation (#374)

* i18n: Add Polish (pl) translation

* i18n: Update and refine Polish (pl) translations

* feat(lang): add spellcheck section to Polish translation

* i18n: keep en first in register and supportedLocales

* i18n: sync pl.json keys with en.json and fill missing translations

* Sync with latest EN + complete Polish translation

* i18n: add missing toast.removedStar + rebase on v0.3.3-dev

---------

Co-authored-by: hkdb <hkdb@3df.io>

* Polish docs

* Bump to v0.3.3

---------

Co-authored-by: dexblasnoot <dex@dexblasnoot.no>
Co-authored-by: aquilapl <81761491+aquilapl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants