Prevent DuckDB token disclosure - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ICEBERG_TOKENwith DuckDBgetenv()instead of embedding its value in generated SQLVERSIONRoot cause
The SQL generator interpolated
Settings.tokeninto aCREATE SECRETstatement. Redirecting the documented command therefore wrote the R2 API token to disk, and entering equivalent SQL directly could expose it through DuckDB CLI history.DuckDB 1.3 added expression support in
CREATE SECRET; this project requires DuckDB 1.4+, sogetenv('ICEBERG_TOKEN')is available.Security impact
Generated SQL and release examples no longer contain the configured R2 token. The credential exists only in the DuckDB process environment and in DuckDB's temporary in-memory secret.
Validation
pytest: 8 passedruff check .: passedgetenv('ICEBERG_TOKEN')and not a sentinel tokengit diff --check: passedCloses #2