Clean up & add createOrbitApp#1
Open
dolanske wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR shuffles a few files around for better readability and also adds a
createOrbitAppcore method, which automatically registers vue router and offloads the main app creation from apps to the core package instead.The idea is that the user needs to do only 3 steps in order to spin up the Orbit front end
createOrbitAppcreateWebPlatform)<OrbitRoot />component in their App.vue application entrypointI removed a few comments from
platform/types.tsas they seemingly randomly documented some object keys but left most of them out. And I think the top-level comment should probably be rephrased and instead be put to README