103. Binary Tree Zigzag Level Order Traversal - #27
Open
hiroki-horiguchi-dev wants to merge 1 commit into
Open
Conversation
nodchip
reviewed
Jun 8, 2026
| } | ||
|
|
||
| Deque<TreeNode> nodes = new ArrayDeque<>(); | ||
| boolean isLeftToRight = true; |
There was a problem hiding this comment.
識別子が動詞の原形や命令形から始まっている場合、関数名のように感じる場合があります。自分なら leftToRight と名付けると思います。
Owner
Author
There was a problem hiding this comment.
コメントありがとうございます。
あれ、本当ですか・・・
is~ を、「その状態かどうか？」を示すフラグ用の変数名として、今まで参画したプロダクトの本番コードでも多々使ってきてしまいました。
| nodes.addLast(root); | ||
|
|
||
| while (!nodes.isEmpty()) { | ||
| // 本当は List<Integer> で受けたいが、jdk21未満だと List に addLast, addFirst がないため、コンパイルエラーになる可能性があるので、LinkedList で受けている。 |
There was a problem hiding this comment.
LinkedList は、 add 毎に新しいオブジェクトが作られ、遅いイメージがあります。実際には速度を計ってみないと何とも言えません。
Deque<Integer> temp = new ArrayDeque<>() を使う手もあります。
https://docs.oracle.com/javase/jp/8/docs/api/java/util/ArrayDeque.html
Owner
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
103. Binary Tree Zigzag Level Order Traversalを解きました