Repository navigation
fix(bbs): one BigBed per 10_final class, named <prefix>.<class>.bb (v0.1.18) - #36
Merged
Merged
Conversation
BEDTOBIGBED_STRONG_RTS, _WEAK_RTS and _ARTIFACTS converted what each strip step kept (STRIP_*.out.hq), not what it removed: on HLangAng1 liver, <prefix>_no_retentions.bb held 212,189 transcripts, while 10_final/strong_rts holds 11,960. Sort and convert STRIP_*.out.discard instead.
BigBed names came from channel ids (<prefix>_flnc@<prefix>_flnc.discard.bb for the truncations, <prefix>.discard.bb for the retentions, <prefix>.bb for the fusions). Set ext.prefix per process to <prefix>.{flnc,truncations,retentions,strong_rts,weak_rts,artifacts,nmd,fusions,scraps}.
NMD-positive transcripts had no BigBed. POLISH now emits the sorted NMD bed, and BEDTOBIGBED_NMD converts it in FULL_RUN, FROM_POLISHING and FROM_ALIGNMENT.
Bump to 0.1.18; README 11_bbs tree and Changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
11_bbs/did not match10_final/:BEDTOBIGBED_STRONG_RTS,BEDTOBIGBED_WEAK_RTSandBEDTOBIGBED_ARTIFACTSconverted what each filter kept (STRIP_*.out.hq), not what it removed. On HLangAng1 liver,HLangAng1_no_retentions.bbheld 212,189 transcripts, while10_final/strong_rtsholds 11,960.HLangAng1_flnc@HLangAng1_flnc.discard.bbheld the truncations,HLangAng1.discard.bbthe retentions andHLangAng1.bbthe fusions.10_final/nmd) had no BigBed.Changes
subworkflows/polish/main.nf: the strong-RT, weak-RT and artifact tracks sort and convertSTRIP_*.out.discard.POLISHemits the sorted NMD bed (SORT_BED_NMD.out.sorted) instead of the unsortedISOTOOLS_NMD.out.nmd; nothing else consumed that emit.main.nf:BEDTOBIGBED_NMDinFULL_RUN,FROM_POLISHINGandFROM_ALIGNMENT.nextflow.config:ext.prefix = "${params.prefix ?: meta.id}.<class>"for each BigBed process, andBEDTOBIGBED_NMDpublished to11_bbs. Version 0.1.18.README.md(the11_bbstree) andChangelog.md(0.1.18).<prefix>_flnc.bb<prefix>.flnc.bb<prefix>_flnc@<prefix>_flnc.discard.bb<prefix>.truncations.bb<prefix>.discard.bb<prefix>.retentions.bb<prefix>_no_retentions.bb(kept set)<prefix>.strong_rts.bb<prefix>_no_retentions_no_strong_rts.bb(kept set)<prefix>.weak_rts.bb<prefix>_no_retentions_no_strong_rts_no_weak_rts.bb(kept set)<prefix>.artifacts.bb<prefix>.nmd.bb<prefix>.bb<prefix>.fusions.bb<prefix>.scraps.bb<prefix>.scraps.bbfusions.free.bed, the fusion-free set, still gets no BigBed. A class with no transcripts still writes no BigBed, as before.Testing
nextflow config -flatfortest,test-sb,test-tm,test-polish,test-rustarandtest-bqc-star.-profile test-polish,docker --skip_bb_conversion false --xorf_call_orfs falsecompletes and writestest.flnc.bb.skip_bb_conversion = true, so CI does not build BigBeds.--from polishon HLangAng1 blood, chromosome SUPER_19 (4,186 metassembly transcripts, xORF on, production parameters).11_bbs/holds exactly the nine files below.bigtools bigbedtobedreturns exactly the rows of its10_finalBED.10_finalrowsHLangAng1.flnc.bbHLangAng1.truncations.bbHLangAng1.retentions.bbHLangAng1.strong_rts.bbHLangAng1.weak_rts.bbHLangAng1.artifacts.bbHLangAng1.nmd.bbHLangAng1.fusions.bbHLangAng1.scraps.bb