Skip to content

fix: expose sanitized AIRegistry upload errors - #343

Merged
learnerjohn merged 1 commit into
higress-group:mainfrom
hhhhzzzj:fix/issue-336-error-details
Aug 20, 2026
Merged

fix: expose sanitized AIRegistry upload errors#343
learnerjohn merged 1 commit into
higress-group:mainfrom
hhhhzzzj:fix/issue-336-error-details

Conversation

@hhhhzzzj

@hhhhzzzj hhhhzzzj commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Description

When AIRegistry rejected a SKILL package, uploadFromZip converted every exception to INTERNAL_ERROR, so validation failures such as an invalid version or unsupported file were hard to diagnose.

This change:

  • reuses the existing TeaException error-code mapping for SKILL uploads;
  • includes a sanitized SDK validation message for mapped client errors;
  • keeps network failures, unknown exceptions, and unmapped Tea errors on the generic INTERNAL_ERROR response;
  • adds regression tests for validation details, sensitive-data removal, and generic failures.

Related Issues

Fix #336

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Testing

  • Unit tests added/updated
  • Code quality checks passed
  • Code is self-reviewed

Commands run:

  • ./mvnw.cmd -pl himarket-server -am -Dtest=AiRegistrySkillServiceImplTest -Dsurefire.failIfNoSpecifiedTests=false test
  • ./mvnw.cmd -q spotless:check -DskipTests
  • ./mvnw.cmd -q -DskipTests test-compile
  • git diff --check

The focused test suite passes with 5 tests.

@CLAassistant

CLAassistant commented Aug 19, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Fix higress-group#336

Signed-off-by: Huang wenxing <3123004612@mail2.gdut.edu.cn>
@hhhhzzzj
hhhhzzzj force-pushed the fix/issue-336-error-details branch from 5a7963b to bbd5f12 Compare August 19, 2026 16:31
@learnerjohn
learnerjohn merged commit a352157 into higress-group:main Aug 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: 期望SKILL上传时能将SKILL错误原因响应

3 participants