fix: expose sanitized AIRegistry upload errors - #343
Merged
learnerjohn merged 1 commit intoAug 20, 2026
Conversation
Fix higress-group#336 Signed-off-by: Huang wenxing <3123004612@mail2.gdut.edu.cn>
hhhhzzzj
force-pushed
the
fix/issue-336-error-details
branch
from
August 19, 2026 16:31
5a7963b to
bbd5f12
Compare
learnerjohn
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When AIRegistry rejected a SKILL package,
uploadFromZipconverted every exception toINTERNAL_ERROR, so validation failures such as an invalid version or unsupported file were hard to diagnose.This change:
TeaExceptionerror-code mapping for SKILL uploads;INTERNAL_ERRORresponse;Related Issues
Fix #336
Type of Change
Testing
Commands run:
./mvnw.cmd -pl himarket-server -am -Dtest=AiRegistrySkillServiceImplTest -Dsurefire.failIfNoSpecifiedTests=false test./mvnw.cmd -q spotless:check -DskipTests./mvnw.cmd -q -DskipTests test-compilegit diff --checkThe focused test suite passes with 5 tests.