Fix compatibility check when mediaDevices is unavailable - #212
Open
volksec wants to merge 1 commit into
Open
Conversation
volksec
marked this pull request as ready for review
July 30, 2026 18:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
eval()-based browser feature checks with guarded accessorsfalsewhennavigator.mediaDevicesis unavailable instead of throwing aTypeErrormediaDevicesand for a fully compatible browser environmentWhy
checkBrowserCompatibility()checksnavigator.mediaDevices.getUserMediaby evaluating the full property path. Whennavigatorexists butmediaDevicesdoes not (for example, in an insecure browser context), evaluating that path throws before the method can report incompatibility and returnfalse.This fixes #211.
Validation
npm test -- --runInBand tests/unit/src/utilities/HiFiUtilities.unit.test.ts— 2 tests passednpm run build:node— passedgit diff --check— passedThe broader unit command passed 25 tests, but two existing suites could not start locally because the native
wrtc.nodebinary was unavailable on Windows.