android: remove legacy support - #241
Conversation
This depends on non-free software. That, in turn, prevents other software, which depends on r-n-f-s to become non-free.
mikehardy
left a comment
mikehardy
left a comment
There was a problem hiding this comment.
But minSdkVersion is 16 here
Granted, that's quite wide and not normally supported these days, but 21 is still likely to be in use throughout the react-native ecosystem as 21 is the current minSdkVersion for react-native itself
So this is a pretty big breaking change to the supported APIs. I don't see any reason why couldn't maintain this in a fork though such that you could use it personally
|
thanks for having a look. For better or worse, it's not about me, personally. This particular module is preventing apps, Joplin in particular, from being shipped through F-Droid, because this module unconditionally depends on proprietary binaries. |
|
I like F-Droid. I like Fully non-proprietary software, I do agree this is a problem. However, my comment stands: the minSdkVersion in the react-native ecosystem is 21 in general and your PR moves it to 24 (by removing support for fingerprint readers on popular devices between API21-23). So I don't think it will go in as is. I recommend using patch-package if F-Droid can handle that (not sure their build system can...) or depending on a fork of your own for this, until minSdkVersion 24 is a reasonable stance for a library |
|
Additionally, the PR should probably include the bump to build.gradle's minSdkVersion to 24 and PR title changed to reflect the same - it's aggressive right now but in a year might be perfect, and then it's just a merge... |
2 participants
Legacy support depends on non-free software.
That, in turn, prevents other software, which depends on r-n-f-s to become non-free.
#240