1. fix error.code; 2. Fix the android cancel button; 3. Add the method of authenticateDevice to enable device password - #133
1. fix error.code; 2. Fix the android cancel button; 3. Add the method of authenticateDevice to enable device password#133orzhtml wants to merge 10 commits into
Conversation
2、安卓修复 lockout 错误的状态 3、其他优化
2、ios 新增 authenticateDevice 方法，唤起设备密码解锁 3、ios 修复 biometric 返回的 code 不正确的问题 4、新增错误消息文案
| if( availableTimes <= 0 ){ | ||
| mReactContext.getJSModule(RCTDeviceEventEmitter.class) | ||
| .emit("FINGERPRINT_SCANNER_AUTHENTICATION", "AuthenticationLockout"); | ||
| }else{ |
There was a problem hiding this comment.
| if( availableTimes <= 0 ){ | |
| mReactContext.getJSModule(RCTDeviceEventEmitter.class) | |
| .emit("FINGERPRINT_SCANNER_AUTHENTICATION", "AuthenticationLockout"); | |
| }else{ | |
| if (availableTimes <= 0) { | |
| mReactContext.getJSModule(RCTDeviceEventEmitter.class) | |
| .emit("FINGERPRINT_SCANNER_AUTHENTICATION", "AuthenticationLockout"); | |
| } else { |
I think general whitespace style (the majority at least) is like this in the file
| .authenticate({ description: 'Log in with Biometrics' }) | ||
| .authenticate({ | ||
| description: 'Scan your fingerprint on the device scanner to continue', | ||
| cancelButton: 'cancel', |
There was a problem hiding this comment.
Was the android implementation using a different signature than iOS before? It is inconvenient to have separate APIs for the platforms, but maybe that is unavoidable
|
I'm just an interested user, not a maintainer or anything, so these are just things I saw, but it may be that no one cares :-), that is fine Here is what I saw: This would be a breaking change because API signatures changed and the change does have default or optional values, but there is no note of that in the README or a CHANGELOG The default return value for iOS was changed but I didn't see that mentioned in the README? The example was not updated to show the changes, it would prove that it worked, this is a large change how have you tested it / how do you show it works without the example altered to match? |
I don't understand what you are saying. Does readme.md have a new API |
|
You changed the API, the docs no longer match https://github.com/hieuvp/react-native-fingerprint-scanner/blob/master/README.md#authenticate-descriptionlog-in-onattempt--null--android |
No API changes |
|
It seems like (2) is a dupe of #120, which was just merged. Please rebase this PR for any differences in functionality for the cancel button. Please separate the functionality for (1) and (3) into individual PRs. |
…rprint-scanner into hieuvp-master # Conflicts: # README.md # android/src/main/java/com/hieuvp/fingerprint/ReactNativeFingerprintScannerModule.java # src/authenticate.android.js
…rprint-scanner into hieuvp-master # Conflicts: # README.md # android/src/main/java/com/hieuvp/fingerprint/ReactNativeFingerprintScannerModule.java # src/authenticate.android.js
Conflict resolved |
…rprint-scanner into hieuvp-master # Conflicts: # android/src/main/java/com/hieuvp/fingerprint/ReactNativeFingerprintScannerModule.java # ios/ReactNativeFingerprintScanner.m
|
Conflict resolved |
3 participants
fix error.code;
Fix the android cancel button;
Add the method of authenticateDevice to enable device password