Skip to content

fix: use pull_request_target for PR automation to fix Dependabot secret access #5922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JeffreyDallas wants to merge 1 commit into from
Closed

fix: use pull_request_target for PR automation to fix Dependabot secret access #5922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/zxf-prs-automation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
name: "ZXF: PR Automation"

on:
pull_request:
# Uses pull_request_target (not pull_request) because Dependabot-triggered pull_request runs
# get a read-only GITHUB_TOKEN and no repository secrets, which breaks the github-token input
# below. Neither job checks out PR code, so running in the base repo's context is safe.
pull_request_target:
types:
- opened
- reopened
Expand Down Expand Up @@ -39,7 +42,7 @@ defaults:
jobs:
auto-assign-merge-queue:
name: "Auto-Assign Merge Queue PRs"
if: github.event_name == 'pull_request' && startsWith(github.base_ref, 'trunk-merge/')
if: github.event_name == 'pull_request_target' && startsWith(github.base_ref, 'trunk-merge/')
runs-on: hiero-solo-linux-medium
steps:
- name: Harden Runner
Expand Down Expand Up @@ -253,7 +256,7 @@ jobs:
}
}

const prEventNames = ['pull_request', 'pull_request_review', 'pull_request_review_comment'];
const prEventNames = ['pull_request_target', 'pull_request_review', 'pull_request_review_comment'];
if (prEventNames.includes(context.eventName)) {
const prNumber = context.payload.pull_request?.number;
if (prNumber) {
Expand Down
Loading