Skip to content

build: register all CI hapi test task as real Test task - #27011

Draft
jjohannes wants to merge 1 commit into
mainfrom
hapi-tests-build-gradle-refactor-2
Draft

build: register all CI hapi test task as real Test task#27011
jjohannes wants to merge 1 commit into
mainfrom
hapi-tests-build-gradle-refactor-2

Conversation

@jjohannes

Copy link
Copy Markdown
Contributor

Description:

Do no longer have logic based on gradle.startParameter.taskNames. Instead, all tasks are registered as Test tasks with the corresponding custom configuration. This has the advantage that (failing) tests are associated with the task that runs them. In general, it makes the setup more straight-forward and idiomatic.

The following beahviour changes compared to main, which does not change how tasks are called from CI:

  • If a task like hapiTestCrypto is called it runs the tests directly instead of doing an ad-hoc reconfiguration of testSubprocess and running that.
  • If two tasks are called together in one Gradle execution – e.g. ./gradlew hapiTestAdhoc hapiTestCrypto both tasks run and execute their tests. Instead of one testSubprocess task that combines the two. ⚠️ In practice we do not use this in the CI pipeline, as the point is to split up things into separate Gradle calls that run independently. Thus I think it is okay to remove this "feature" as it is not (and probably never was) actively used ⚠️.

Related issue(s):

Follow up to #26945

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@jjohannes jjohannes added this to the v0.79 milestone Aug 28, 2026
@jjohannes jjohannes self-assigned this Aug 28, 2026
@lfdt-bot

lfdt-bot commented Aug 28, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Do no longer have logic based on 'gradle.startParameter.taskNames'
checks. Instead, all tasks are registered as 'Test' tasks with the
corresponding custom configuration. This has the advantage that
(failing) test are associated with the task that runs them.
In general, it makes the setup more straight-forward and idiomatic.

Signed-off-by: Jendrik Johannes <jendrik@onepiece.software>
@jjohannes
jjohannes force-pushed the hapi-tests-build-gradle-refactor-2 branch from fc62fef to 73db260 Compare August 28, 2026 08:42
@testlens-app

testlens-app Bot commented Aug 28, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

⚠️ TestLens detected flakiness ⚠️

Test Summary

600: [FLOW] PR Checks / MATS / HAPI Tests / hapi-tests-misc / HAPI Tests (Misc) > :test-clients:hapiTestMisc

Test Runs Flakiness
HollowAccountsAndKeysBatchTest > BatchKey rotation inside batch: one inner tx with old batch key, should pass > as written ❌ ✅ 0% 🟢

600: [FLOW] PR Checks / MATS / HAPI Tests / hapi-tests-misc-records-crypto-and-serial / HAPI Tests (Misc Records, Crypto & Misc Serial) > :test-clients:hapiTestCrypto

Test Runs Flakiness
ConcurrentSubprocessValidationTest > validateLogsAndStreams() > as written ❌ ✅ 0% 🟢

🏷️ Commit: 73db260
▶️ Tests: 922 executed
⚪️ Checks: 43/43 completed


Learn more about TestLens at testlens.app/docs.

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #27011      +/-   ##
============================================
- Coverage     70.54%   70.54%   -0.01%     
  Complexity    11691    11691              
============================================
  Files          2586     2586              
  Lines        108553   108553              
  Branches      12166    12166              
============================================
- Hits          76584    76581       -3     
- Misses        27971    27973       +2     
- Partials       3998     3999       +1     

see 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants