fix: introduce a max in progress block count that can trigger back pressure - #26993
Open
timfn-hg wants to merge 3 commits into
Open
fix: introduce a max in progress block count that can trigger back pressure#26993timfn-hg wants to merge 3 commits into
timfn-hg wants to merge 3 commits into
Conversation
…essure Signed-off-by: Tim Farber-Newman <tim.farber-newman@swirldslabs.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Signed-off-by: Tim Farber-Newman <tim.farber-newman@swirldslabs.com>
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #26993 +/- ##
============================================
+ Coverage 70.55% 70.56% +0.01%
+ Complexity 11692 11691 -1
============================================
Files 2586 2586
Lines 108553 108570 +17
Branches 12165 12168 +3
============================================
+ Hits 76586 76610 +24
+ Misses 27970 27964 -6
+ Partials 3997 3996 -1
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
Author
✅ All tests passed ✅🏷️ Commit: 9261cae Learn more about TestLens at testlens.app/docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Create a new configuration that allows us to specify the maximum number of in-progress blocks within the block buffer to catch cases where upstream blocks are not able to be closed for some reason. In this case, we want to trigger back pressure sooner rather than later since it means there is a problem with the blocks and we should be more aggressive in applying back pressure to decrease the risk of data issues.
At any given moment there is always likely to be one block in progress, so applying this new configuration doesn't kick in unless at least 2 blocks are in progress. This means that aside from the latest block, there are older blocks that have yet to be closed. The threshold is currently 5 blocks.
Related issue(s):
Fixes #26949
Notes for reviewer:
Checklist