Skip to content

chore: Add failure threshold to Falcon tests - #26936

Open
poulok wants to merge 1 commit into
mainfrom
26800-falcon-failure-threshold
Open

chore: Add failure threshold to Falcon tests#26936
poulok wants to merge 1 commit into
mainfrom
26800-falcon-failure-threshold

Conversation

@poulok

@poulok poulok commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Fixes #26800

Signed-off-by: Kelly Greco <kelly@swirldslabs.com>
@poulok poulok added this to the v0.79 milestone Aug 21, 2026
@poulok
poulok requested a review from netopyr August 21, 2026 19:22
@poulok poulok self-assigned this Aug 21, 2026
@poulok
poulok requested a review from a team as a code owner August 21, 2026 19:22
@lfdt-bot

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@testlens-app

testlens-app Bot commented Aug 21, 2026

Copy link
Copy Markdown

🚨 TestLens detected 1 failed test 🚨

Here is what you can do:

  1. Inspect the test failures carefully.
  2. If you are convinced that some of the tests are flaky, you can mute them below.
  3. Finally, trigger a rerun by checking the rerun checkbox.

Test Summary

600: [FLOW] PR Checks / MATS / Unit Tests / Unit Tests > :consensus-otter-tests:test

Test Runs Flakiness
Falcon failure threshold Test > A sweep without a threshold runs every repetition, no matter how many fail 0% 🟢

🏷️ Commit: 81f3ac7
▶️ Tests: 1344 executed
⚪️ Checks: 53/53 completed

Test Failures

Falcon failure threshold Test > A sweep without a threshold runs every repetition, no matter how many fail (:consensus-otter-tests:test in 600: [FLOW] PR Checks / MATS / Unit Tests / Unit Tests)
org.opentest4j.AssertionFailedError: 
Expecting value to be false but was true
	at org.hiero.otter.fixtures@0.79.0-SNAPSHOT/org.hiero.otter.fixtures.junit.FalconFailureThresholdTest.sweepWithoutThresholdRunsEveryRepetition(FalconFailureThresholdTest.java:34)
	at java.base/java.lang.reflect.Method.invoke(Method.java:565)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)
expected actual
false true

Rerun Controls

Note

Muting tests is disabled for this repository.

Select tests to mute in this pull request:

🔲 Falcon failure threshold Test > A sweep without a threshold runs every repetition, no matter how many fail

Reuse successful test results:

  • ♻️ Only rerun the tests that failed or were muted before

Click the checkbox to trigger a rerun:

  • Rerun jobs

Learn more about TestLens at testlens.app/docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add failure threshold

2 participants