Skip to content

chore: Ensure inbound statusz request returns empty if known publishers is empty. - #3572

Open
jsync-swirlds wants to merge 2 commits into
mainfrom
3540-tie-inbound-to-known-publishers
Open

chore: Ensure inbound statusz request returns empty if known publishers is empty.#3572
jsync-swirlds wants to merge 2 commits into
mainfrom
3540-tie-inbound-to-known-publishers

Conversation

@jsync-swirlds

@jsync-swirlds jsync-swirlds commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Reviewer Notes

  • Adjusted inbound status handler to return empty NetworkData if known publishers is empty.
  • Removed one high-frequency, and unnecessary, trace log.

Related Issue(s)

Resolves #3540

…rs is empty.

* Adjusted inbound status handler to return empty `NetworkData` if
  known publishers is empty.

Signed-off-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com>
@jsync-swirlds jsync-swirlds added this to the 0.42.0 milestone Aug 29, 2026
@jsync-swirlds jsync-swirlds self-assigned this Aug 29, 2026
@jsync-swirlds
jsync-swirlds requested review from a team as code owners August 29, 2026 01:36
@jsync-swirlds jsync-swirlds added the Health Plugin Issue related to Health Plugin label Aug 29, 2026
@jsync-swirlds
jsync-swirlds requested review from AlfredoG87, ata-nas and ivannov and removed request for jasperpotts August 29, 2026 01:37
Signed-off-by: Joseph S. <121976561+jsync-swirlds@users.noreply.github.com>
@codecov

codecov Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...tream/subscriber/BlockStreamSubscriberSession.java 0.00% 1 Missing ⚠️
@@             Coverage Diff              @@
##               main    #3572      +/-   ##
============================================
- Coverage     83.66%   83.65%   -0.02%     
+ Complexity     2596     2594       -2     
============================================
  Files           219      219              
  Lines         11377    11379       +2     
  Branches       1331     1332       +1     
============================================
  Hits           9519     9519              
- Misses         1365     1368       +3     
+ Partials        493      492       -1     
Files with missing lines Coverage Δ Complexity Δ
.../hiero/block/node/health/InboundStatusHandler.java 100.00% <100.00%> (ø) 3.00 <0.00> (+1.00)
...tream/subscriber/BlockStreamSubscriberSession.java 71.91% <0.00%> (-0.09%) 80.00 <0.00> (-3.00)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Health Plugin Issue related to Health Plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: fix handling when backfill configured but known-publishers is not.

1 participant