Repository navigation
Third-party notices and Statamic Marketplace review fixes (0.1.1) - #2
Merged
Merged
Conversation
- THIRD-PARTY-NOTICES with the copyright and MIT texts of pusher-js, @stablelib/base64, @stablelib/utf8 and qrcode-generator, which dist/cp.js bundles; it ships in the release archive. dist/cp.js gets a short notice banner and keeps legal comments at the end. - Events are sent after the response, so a save never waits on Hibira. - Comment events carry only the ID; pages fetch the comment, so long comments never meet the plan's message size limit. - Encode the comment file with JSON_THROW_ON_ERROR before truncating it, and refuse comments with invalid UTF-8. - Comments card: load failure with retry, old errors cleared on success. - README: Statamic Pro, data passing through Hibira (Hong Kong), plan limits, support contact. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SHtsCEpcc5kbQCJWL3ZMYZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Danny · project thread
Addresses the Statamic Marketplace review of v0.1.0.
Required (Rule 08)
THIRD-PARTY-NOTICESwith the copyright notices and MIT texts of everythingdist/cp.jsbundles: pusher-js 8.6.0, @stablelib/base64 and @stablelib/utf8 (bundled inside pusher-js), and qrcode-generator 1.5.2.export-ignore; checked that it appears ingit archiveoutput.dist/cp.jsnow starts with a short/*! … */banner naming the libraries and pointing at the file, and keeps legal comments at the end (--legal-comments=eof).Optional fixes
Realtime::trigger()queues events and sends them in anapp()->terminating()callback, so saves never wait on Hibira. Outside HTTP (queue workers) it still sends at once.JSON_THROW_ON_ERRORbefore the file is truncated; the controller also refuses bodies that aren't valid UTF-8 (422).{action, id}; other pages refetch the list (bursts are folded into one extra fetch), so comment size never meets the message size limit.…; errors clear after a later success or when typing. Newload_failed/retrystrings in all 7 languages.Tests
vendor/bin/phpunit: 28 tests OK (new: ID-only events, invalid UTF-8 refused, encode failure leaves file intact, saved event deferred until terminate).npm run buildreproducesdist/.Generated by Claude Code