Repository navigation
Support encrypted channels with a Pusher prop on HibiraProvider (0.3.0) - #8
Merged
Merged
Conversation
The default browser build of pusher-js has no NaCl, so encrypted channels failed unless you built and passed your own client. Pass the class from pusher-js/with-encryption instead. Adds a README section, a unit test, a type test and an end-to-end test against a real server. Release 0.3.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SHtsCF9LUzGnmMxYox3ZKU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Danny · project thread
What does this change?
The default browser build of pusher-js has no NaCl, so subscribing to an end-to-end encrypted
private-encrypted-channel failed unless you built and passed your own client. This adds aPusherprop toHibiraProvider: pass the class frompusher-js/with-encryptionand encrypted channels work, with the Hibira defaults and the provider's lifecycle kept. README gets an "Encrypted channels" section. Version 0.3.0.How was it tested?
npm test, 40 pass), plus a type test (npm run typecheck).pusherwithencryptionMasterKeyBase64) triggers on aprivate-encrypted-channel anduseEventgets the decrypted payload. All e2e tests pass.Checklist
Generated by Claude Code