Repository navigation
Fix CI on 3.9 and raise hibira.ConnectionError for network failures - #2
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SHtsCCHwKcFDPRqugEWRfU
httpx transport errors (DNS, connect, TLS, proxy, timeout) escaped as raw httpx exceptions, so except hibira.HibiraError missed them. They now raise hibira.ConnectionError, a HibiraError and a builtin ConnectionError. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SHtsCCHwKcFDPRqugEWRfU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits that landed after #1 was merged. Both should go in before tagging v0.1.0.
setup-uvnow creates and activates the test virtualenv.setup-pythonhas no Python 3.9 on the currentubuntu-latest, anduv pip installwithout a venv failed on every version, so the test matrix onmainis red right now.except hibira.HibiraErrormissed them. They now raisehibira.ConnectionError, which is both aHibiraErrorand a builtinConnectionError, with the httpx error as__cause__. This applies toClientandAsyncClient. The django-hibira work asked for this.Ran locally: 44 tests pass, plus ruff and mypy.
Generated by Claude Code