Add support for AMD. - #2
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Vulkan Video encoder path to better support AMD/RADV drivers by aligning coded extents to device-reported granularities, handling DPB limitations (layered DPB fallback), and separating upload/encode queue usage where needed.
Changes:
- Add capability-driven coded-extent alignment (granularity + min/max coded extent) and query/selection of supported SRC/DPB formats.
- Add layered-DPB fallback when
SEPARATE_REFERENCE_IMAGESisn’t supported and centralize DPB barrier recording. - Use transfer-queue command resources for uploads, add shared cleanup helper, and tighten validation-layer/extension enabling.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vulkan.rs | Make validation-layer/validation-features enabling conditional on availability. |
| src/image.rs | Add device_wait_idle() before destroying InputImage resources. |
| src/encoder/resources.rs | Add alignment helpers, concurrent sharing for input images when queue families differ, split upload vs encode command pools, layered DPB creation path, centralized resource destruction + DPB barrier helper. |
| src/encoder/h265/mod.rs | Route uploads through transfer queue; switch Drop cleanup to shared destroy helper; track layered DPB usage. |
| src/encoder/h265/init.rs | Compute coded extent from capabilities; choose supported formats; enable layered DPB fallback; chain quality-level info; split upload vs encode command resources. |
| src/encoder/h265/encode.rs | Use centralized DPB barrier recording; combine RESET+RC+QUALITY control command; layered-DPB-aware post-encode barrier. |
| src/encoder/h265/upload.rs | Removed (upload now handled directly in mod.rs via shared upload helper). |
| src/encoder/h264/mod.rs | Route uploads through transfer queue; switch Drop cleanup to shared destroy helper; store aligned coded extent; track layered DPB usage. |
| src/encoder/h264/init.rs | Add more capability logging; align coded extent; chain quality-level info; layered DPB fallback; split upload vs encode command resources; update SPS/PPS defaults for AMD stability. |
| src/encoder/h264/encode.rs | Use centralized DPB barrier recording; align coded extent in picture resources; combine RESET+RC+QUALITY control command; adjust RC disabled handling. |
| src/encoder/h264/upload.rs | Removed (upload now handled directly in mod.rs via shared upload helper). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.