Test APK installation in CI - #83
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughChangesAPK installation validation
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant CI
participant Alpine3241 as Alpine 3.24.1
participant APK as network-doctor APK
participant Binaries as Installed binaries
CI->>Alpine3241: Start pinned container with network disabled
CI->>Alpine3241: Install APK with apk add
Alpine3241->>APK: Register network-doctor package
Alpine3241->>Binaries: Place netdoc and netdoc-sim in /usr/bin
CI->>Binaries: Run netdoc --version and netdoc-sim version
Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change adds CI coverage for installing and running both packaged binaries in Alpine. The supplied checks show no remaining merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
apkrecordsnetwork-doctoras installednetdocandnetdoc-simare installed at/usr/binValidation
./scripts/checkapk info -e network-doctornetdoc --versionnetdoc-sim versionCloses #42
Summary by CodeRabbit