Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 104 additions & 0 deletions .github/workflows/benchmark-post.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,104 @@
name: Benchmark - Post Process

on:
workflow_run:
workflows: ["Benchmark"]
types:
- completed

permissions:
contents: read

jobs:
profiling-preview:
if:
${{ github.event_name == 'workflow_run' && github.event.workflow_run.event
== 'pull_request' && github.event.workflow_run.conclusion == 'success' }}
runs-on: ubuntu-slim
environment:
name: "profiling-preview"
url: ${{ steps.get_info.outputs.url }}
deployment: false
permissions:
actions: read # download artifacts from the triggering workflow run
contents: read
pull-requests: write # for marocchino/sticky-pull-request-comment to create or update PR comment
env:
comment_result: "tmp-comment-flamegraph.md"
steps:
- uses: actions/download-artifact@v8
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
run-id: ${{ toJSON( github.event.workflow_run.id ) }}
pattern: "flamegraph-*"
path: ./flamegraph/
merge-multiple: true

- name: Get PR info
id: get_info
uses: actions/github-script@v8
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
const run = context.payload.workflow_run;
let pullRequests = run.pull_requests || [];

if (pullRequests.length !== 1) {
if (!run.head_repository || !run.head_branch) {
throw new Error(`Missing head repository metadata for workflow run ${run.id}`);
}

const response = await github.rest.pulls.list({
owner: context.repo.owner,
repo: context.repo.repo,
state: 'all',
head: `${run.head_repository.owner.login}:${run.head_branch}`,
base: context.payload.repository.default_branch
});

pullRequests = response.data.filter(pullRequest => (
pullRequest.head.sha === run.head_sha
&& pullRequest.base.repo.full_name === `${context.repo.owner}/${context.repo.repo}`
&& pullRequest.base.ref === context.payload.repository.default_branch
));
}

if (pullRequests.length !== 1) {
throw new Error(`Expected one pull request for workflow run ${run.id}, found ${pullRequests.length}`);
}

const prNumber = pullRequests[0].number;
if (!Number.isSafeInteger(prNumber) || prNumber < 1) {
throw new Error(`Invalid pull request number for workflow run ${run.id}`);
}

core.setOutput('pr_number', prNumber);
core.setOutput('url', `https://${prNumber}-pr-hexo.surge.sh/`);

- name: Publish flamegraph to ${{ steps.get_info.outputs.url }}
uses: dswistowski/surge-sh-action@v1
with:
domain: ${{ steps.get_info.outputs.url }}
project: ./flamegraph/
login: ${{ secrets.SURGE_LOGIN }}
token: ${{ secrets.SURGE_TOKEN }}

- name: Print full URLs
env:
preview_url: ${{ steps.get_info.outputs.url }}
run: |
{
echo "## Flamegraph"
echo ""
for node_version in 20 22 24; do
echo "${preview_url}${node_version}/flamegraph.html"
done
} | tee "${{ env.comment_result }}" >> "$GITHUB_STEP_SUMMARY"

- name: Comment PR - flamegraph
uses: marocchino/sticky-pull-request-comment@v3
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
number: ${{ steps.get_info.outputs.pr_number }}
header: Flamegraph
path: ${{ env.comment_result }}
64 changes: 38 additions & 26 deletions .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@
os: [ubuntu-latest]
node-version: ["20", "22", "24"]
fail-fast: false
env:
comment_file: "tmp-comment-flamegraph-node${{ matrix.node-version }}.md"
steps:
- uses: actions/checkout@v7
- name: Use Node.js ${{ matrix.node-version }}
Expand All @@ -53,37 +51,51 @@
run: npm install --silent
- name: Running profiling
run: node test/benchmark.js --profiling
- name: Publish flamegraph to https://${{ github.sha }}-${{ matrix.node-version }}-hexo.surge.sh/flamegraph.html
uses: dswistowski/surge-sh-action@v1
with:
domain: ${{ github.sha }}-${{ matrix.node-version }}-hexo.surge.sh
project: ./.tmp-hexo-theme-unit-test/0x/
login: ${{ secrets.SURGE_LOGIN }}
token: ${{ secrets.SURGE_TOKEN }}

- name: save comment to file
if: ${{github.event_name == 'pull_request' }}
- name: mv flamegraph
run: |
echo "https://${{ github.sha }}-${{ matrix.node-version }}-hexo.surge.sh/flamegraph.html" > ${{env.comment_file}}
mkdir -p ./flamegraph/
mv ./.tmp-hexo-theme-unit-test/0x/ ./flamegraph/${{ matrix.node-version }}/

- uses: actions/upload-artifact@v7
if: ${{github.event_name == 'pull_request' }}
with:
retention-days: 1
name: comment-node${{ matrix.node-version }}
path: ${{env.comment_file}}
name: flamegraph-node${{ matrix.node-version }}
path: ./flamegraph/

number:
runs-on: ubuntu-latest
if: ${{github.event_name == 'pull_request' }}
profiling-preview:
needs: profiling
if: ${{ github.event_name != 'pull_request' }}
runs-on: ubuntu-slim
environment:
name: 'profiling-preview'
url: ${{ env.url }}
deployment: false
permissions:
contents: read
env:
pr_number_file: tmp-comment-pr_number
url: https://${{ github.sha }}-hexo.surge.sh/
steps:
- name: save PR number to file
run: |
echo -n "${{ github.event.number }}" > ${{env.pr_number_file}}
- uses: actions/upload-artifact@v7
- uses: actions/download-artifact@v8
with:
retention-days: 1
name: comment-pr_number
path: ${{env.pr_number_file}}
pattern: "flamegraph-*"
path: ./flamegraph/
merge-multiple: true

- name: Publish flamegraph to ${{ env.url }}
uses: dswistowski/surge-sh-action@v1
with:
domain: ${{ env.url }}
Comment on lines +77 to +88
project: ./flamegraph/
login: ${{ secrets.SURGE_LOGIN }}
token: ${{ secrets.SURGE_TOKEN }}

- name: Print full URLs
run: |
{
echo "## Flamegraph"
echo ""
for node_version in 20 22 24; do
echo "${{ env.url }}${node_version}/flamegraph.html"
done
} | tee -a "$GITHUB_STEP_SUMMARY"
43 changes: 0 additions & 43 deletions .github/workflows/commenter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,6 @@ name: Commenter
on:
pull_request_target:

workflow_run:
workflows: ["Benchmark"]
types:
- completed

permissions:
contents: read

Expand All @@ -32,41 +27,3 @@ jobs:
npm install
npm test
```

comment-flamegraph:
name: Flamegraph
permissions:
pull-requests: write # for marocchino/sticky-pull-request-comment to create or update PR comment
actions: read # get artifact
runs-on: ubuntu-latest
if: ${{github.event_name == 'workflow_run' && github.event.workflow_run.conclusion=='success'}}
env:
comment_result: "tmp-comment-flamegraph.md"
steps:
- name: download artifact
uses: actions/download-artifact@v8
with:
github-token: ${{secrets.GITHUB_TOKEN}}
run-id: ${{toJSON(github.event.workflow_run.id)}}
pattern: "comment-*"
merge-multiple: true

- name: get PR number
run: |
echo "pr_number=$(cat tmp-comment-pr_number)" >> "$GITHUB_ENV"

- name: combime comment
if: ${{env.pr_number!=''}}
run: |
echo "## Flamegraph" > ${{env.comment_result}}
echo "" >> ${{env.comment_result}}
cat tmp-comment-flamegraph-*.md >> ${{env.comment_result}}

- name: Comment PR - flamegraph
if: ${{env.pr_number!=''}}
uses: marocchino/sticky-pull-request-comment@v3
with:
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
number: ${{env.pr_number}}
header: Flamegraph
path: ${{env.comment_result}}