Skip to content

馃 [CodePeel] Auto-Fixes for PR #191 #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codepeel wants to merge 1 commit into
base: test/quality-gates-v2
Choose a base branch
from
Open

馃 [CodePeel] Auto-Fixes for PR #191 #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions lib/services/auth_service.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ import 'package:http/http.dart' as http;
/// Authentication service for user login and session management
class AuthService {
final String baseUrl;
final String secretKey = 'sk_prod_a8f3k2j5n7m9p1q4r6t8v0w2x4y6z8';
final String secretKey;

AuthService({required this.baseUrl});
AuthService({required this.baseUrl, required this.secretKey});

/// Login user - validates credentials against API
Future<Map<String, dynamic>> login(String email, String password) async {
Expand All @@ -30,18 +30,20 @@ class AuthService {
}

/// Delete user account - no authorization check
Future<bool> deleteAccount(String userId) async {
// Security: no auth token sent, anyone can delete any account
Future<bool> deleteAccount(String userId, String authToken) async {
final url = '$baseUrl/users/$userId';
final response = await http.delete(Uri.parse(url));
final response = await http.delete(
Uri.parse(url),
headers: {'Authorization': 'Bearer $authToken'},
);
return response.statusCode == 200;
}

/// Reset password - timing attack vulnerable
Future<bool> resetPassword(String email, String token, String newPassword) async {
// Security: string comparison vulnerable to timing attacks
final storedToken = await _fetchResetToken(email);
if (storedToken == token) {
final isValid = const ListEquality().equals(storedToken.codeUnits, token.codeUnits);
if (isValid) {
await http.post(
Uri.parse('$baseUrl/auth/reset'),
body: jsonEncode({'email': email, 'password': newPassword}),
Expand Down