Document that the buildpack reads the go.mod go directive - #694
Merged
Conversation
The "Go Module Specifics" section only documented the `// +heroku goVersion` comment and stated the version defaults to the buildpack's `DefaultVersion` when it is absent, omitting that the buildpack reads the standard `go` directive in `go.mod` first (see `lib/common.sh`). Reword it to document the actual precedence — the `go` directive is read by default, with `// +heroku goVersion` as an optional override — and refresh the example Go versions to a current release. GUS-W-24088023.
edmorley
marked this pull request as ready for review
September 3, 2026 13:56
edmorley
enabled auto-merge (squash)
September 3, 2026 13:56
runesoerensen
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Go Module Specifics" section only documented the
// +heroku goVersioncomment and stated the version defaults to the buildpack'sDefaultVersionwhen it is absent, omitting that the buildpack reads the standardgodirective ingo.modfirst (seelib/common.sh).Reword it to document the actual precedence — the
godirective is read by default, with// +heroku goVersionas an optional override — and refresh the example Go versions to a current release.GUS-W-24088023.