Fix stale LLM node running state - #67
Open
MEIS-DaCaiTou wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes stale "running" indicators on Smart Canvas LLM prompt nodes.
When an LLM prompt node starts, the UI sets
node.running = true. If the canvas is saved while that request is in flight, the transient running state can be persisted into the canvas JSON. The LLM completion path clears the in-memory flag, but did not schedule another save afternode.running = false, so a refresh or later reopen could continue to show nodes as running even when no request is active.This also filters chat model names containing
*from the model selector. Values likegemini-3-pro-preview-thinking-*behave like wildcard placeholders rather than concrete model IDs, and can lead to provider errors when selected as-is.Changes
runningflags before saving canvas nodes.runningflags while loading a canvas.*from chat model options.Validation
node --check static/js/smart-canvas.jssuccessfully.