Skip to content

Bump dune version - #1948

Merged
hrutvik merged 2 commits into
herd:masterfrom
hrutvik:bump-dune
Aug 7, 2026
Merged

Bump dune version#1948
hrutvik merged 2 commits into
herd:masterfrom
hrutvik:bump-dune

Conversation

@hrutvik

@hrutvik hrutvik commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Require 3.14 minimum. In practice, this means getting 3.15.3 from opam.

The motivation for this is that dynamic_include was introduced in 3.14, which allows dune files to be generated on-the-fly and included without checking in to the source repo - see these docs. This allows for a pattern where e.g.

  • test files and their expected outputs are checked in
  • dune runtest generates a dune file on-the-fly, containing a rule for each test + expected output, and each rule runs a test harness to check actual vs. expected outputs
  • dune functionality such as diffing and promotion work as expected

@hrutvik

hrutvik commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator Author

@solswords I notice that acl2/asl/aslreftests/dune-project has lang dune 3.16, which I think may be beyond our minimum supported version. Is there a need for any 3.16-specific functionality, or could e.g. 3.14 suffice?

@fsestini

fsestini commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Hi @hrutvik , is this still a draft/work-in-progress or is it ready for review?
If it's ready, could you please add to the PR description the motivation for this bump, just for our records?

@hrutvik
hrutvik marked this pull request as ready for review August 3, 2026 15:45
@hrutvik

hrutvik commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator Author

Updated!

@fsestini fsestini left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@solswords

solswords commented Aug 3, 2026 via email

Copy link
Copy Markdown
Collaborator

@fsestini

fsestini commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Hi @hrutvik , do you think this can now be rebased and merged?

hrutvik added 2 commits August 6, 2026 16:42
Require 3.14 minimum. In practice, this means getting 3.15.3 from `opam`.
@hrutvik

hrutvik commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

Apologies, yes - will merge once CI passes

@hrutvik
hrutvik merged commit 4dc74f8 into herd:master Aug 7, 2026
12 of 25 checks passed
@hrutvik
hrutvik deleted the bump-dune branch August 7, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants