Bump dune version - #1948
Merged
Merged
Conversation
Collaborator
Author
|
@solswords I notice that |
HadrienRenaud
approved these changes
Aug 3, 2026
Collaborator
|
Hi @hrutvik , is this still a draft/work-in-progress or is it ready for review? |
hrutvik
marked this pull request as ready for review
August 3, 2026 15:45
Collaborator
Author
|
Updated! |
Collaborator
|
3.14 seems to work -- feel free to change it.
…On Mon, Aug 3, 2026 at 9:45 AM Hrutvik Kanabar ***@***.***> wrote:
*hrutvik* left a comment (herd/herdtools7#1948)
<#1948 (comment)>
@solswords <https://github.com/solswords> I notice that
acl2/asl/aslreftests/dune-project has lang dune 3.16, which I think may
be beyond our minimum supported version. Is there a need for any 3.16-specific
functionality, or could e.g. 3.14 suffice?
—
Reply to this email directly, view it on GitHub
<#1948?email_source=notifications&email_token=ABJLGKPHDOJMGX4B2BHVIAT5ICQRHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJWG44DMMRTG4YKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5167862370>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJLGKJI6IP3O4WROZONGQL5ICQRHAVCNFSNUABEKJSXA33TNF2G64TZHM3TGMJQGQZDEMZ3JFZXG5LFHM2TANJRGAYDGNJTHGQXMAQ>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/ABJLGKJSOAWA2ASHEDENI4L5ICQRHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJWG44DMMRTG4YKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/ABJLGKOJM3HKYRGFPENLIJL5ICQRHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJWG44DMMRTG4YKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
psafont
approved these changes
Aug 3, 2026
Collaborator
|
Hi @hrutvik , do you think this can now be rebased and merged? |
Require 3.14 minimum. In practice, this means getting 3.15.3 from `opam`.
Collaborator
Author
|
Apologies, yes - will merge once CI passes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require 3.14 minimum. In practice, this means getting 3.15.3 from
opam.The motivation for this is that
dynamic_includewas introduced in 3.14, which allows dune files to be generated on-the-fly and included without checking in to the source repo - see these docs. This allows for a pattern where e.g.dune runtestgenerates adunefile on-the-fly, containing a rule for each test + expected output, and each rule runs a test harness to check actual vs. expected outputsdunefunctionality such as diffing and promotion work as expected