[catalogue] Fix catalogue - #1939
Open
maranget wants to merge 5 commits into
Open
Conversation
The "anarchy" (define coherence order and no consitency check) model is restored. Noticeably we erase PTX tests, as herd no longer supports this architecture.
Minor fix: update a call to the ctrlcfence function from the Cat standard library.
fsestini
reviewed
Jul 31, 2026
| begin match eval_ord env e with | ||
| | V.Empty -> V.Empty | ||
| | Unv -> Rel (Lazy.force env.EV.ks.id) | ||
| | Event e -> Rel (E.EventRel.singleton (e,e)) |
Collaborator
There was a problem hiding this comment.
Out of curiosity, what problem is this line addressing? What is an example of a ToId operator with an Event operand?
Member
Author
There was a problem hiding this comment.
Well I could have made a separate PR the code is let succs (e,r) = range ([e];r), where e is a single event. This code was working before,because the Cat interpreter was systematically using the same function (eval_events) when an event set is expected. The function eval_events performs the silent promotion of one event into a singleton set. Since for instance PR #1855, the evaluation of sets has become more complex and this case of [e] where e is an event had been overlooked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix various problems in the catalogue.