[aslref] complete annotations for all left-/right- hand side expressions - #1924
Closed
Roman-Manevich wants to merge 1 commit into
Closed
[aslref] complete annotations for all left-/right- hand side expressions#1924Roman-Manevich wants to merge 1 commit into
Roman-Manevich wants to merge 1 commit into
Conversation
Roman-Manevich
requested review from
HadrienRenaud and
hrutvik
and removed request for
hrutvik
July 21, 2026 21:42
Roman-Manevich
marked this pull request as ready for review
July 21, 2026 21:43
Roman-Manevich
force-pushed
the
asl-type-annotation-completion
branch
from
July 22, 2026 12:49
2b8b5dd to
61b2138
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an optional post-typechecking pass that completes missing expression and assignable-expression type annotations in the typed AST. Enabling this pass is done in code by turning
complete_type_annotationstotruein the configuration forTyping/ANNOTATE_CONFIG.The pass preserves existing typechecker annotations and fills holes introduced by normalization, inserted parameters, and synthesized base values. Where precise typing information is unavailable, normalized integer expressions and inserted parameters receive an unconstrained integer type.
This completion is consumer-facing metadata and is not part of the ASL type system. It does not change typing judgments or the resulting static environment. It runs only after successful strict typechecking.
Testing
ran
dune runtest asllibwith completion and validation switches turned on (they are turned off by default).This PR is AI-assisted.