[herd] Replace mentions of Hardware Update Effects with Implicit TTD Write Effects - #1920
Open
fsestini wants to merge 1 commit into
Open
[herd] Replace mentions of Hardware Update Effects with Implicit TTD Write Effects#1920fsestini wants to merge 1 commit into
fsestini wants to merge 1 commit into
Conversation
fsestini
changed the title
|
|
||
| let data = [Exp & R]; dtrm & po; [Rreg]; iico_data & ii_data; [Exp & W] | ||
| let addr = [Exp & R]; dtrm & po; [Rreg]; iico_data & ii_addr; [Exp & M | Imp & Tag & R | Imp & TTD & R | HU | TLBI | DC.CVAU | IC.IVAU] | ||
| let addr = [Exp & R]; dtrm & po; [Rreg]; iico_data & ii_addr; [Exp & M | Imp & Tag & R | Imp & TTD & M | TLBI | DC.CVAU | IC.IVAU] |
Collaborator
There was a problem hiding this comment.
I know TTD & M has been used elsewhere, but cat2table currently assumes TTD is a subset of M, which is also confirmed by the aarch64assumptions.cat file, ran across the test suite. I'm wondering if we can leave this occurrence as Imp & TTD. Perhaps Imp & TTD & M might still be better in order to keep miaou7 output consistent with Arm ARM proses. What do you think?
Collaborator
Author
There was a problem hiding this comment.
Perhaps
Imp & TTD & Mmight still be better in order to keepmiaou7output consistent with Arm ARM proses.
Yes.
Collaborator
|
LGTM, but I'm going to hold off on this until tickets are made official and communicated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: