[asl reference] replace console splicing by generated console macros - #1919
[asl reference] replace console splicing by generated console macros#1919Roman-Manevich wants to merge 4 commits into
Conversation
| @@ -1,8 +1,10 @@ | |||
| ASLREF=../../_build/install/default/bin/aslref | |||
| ASLREF=../../_build/default/asllib/aslref.exe | |||
There was a problem hiding this comment.
Could something like dune show location aslref work here instead?
There was a problem hiding this comment.
dune show location aslref points to public install path (./../_build/install/default/bin/aslref), but we need the path created by the makefile rule for $(ASLREF). I don't know how to make it point to the right path.
There was a problem hiding this comment.
How about dune show location ../aslref.exe?
There was a problem hiding this comment.
That returns _build/default/asllib/aslref.exe
There was a problem hiding this comment.
I'm not sure I understand - that can be prefixed by ../../ to get the right result can't it?
47f22df to
0425492
Compare
0425492 to
182bfa2
Compare
| BIBTEX=bibtex | ||
|
|
||
| GENERATED_MACROS_TEX=generated_macros.tex | ||
| # Empty file marking successful generation of every file in generated_console_output/. |
There was a problem hiding this comment.
I'm a bit surprised by this - is a .PHONY target in the Makefile not sufficient to model this?
There was a problem hiding this comment.
The command generates one file per \RenderConsoleFor macro invocation. There are currently 27 of those files (HeVeA needs those files seprately). A .PHONY target would regenerate them and rebuild the document every time. The stamp gives you incremental builds.
There was a problem hiding this comment.
Was this comment supposed to be on the other thread?
182bfa2 to
1e026c0
Compare
HadrienRenaud
left a comment
HadrienRenaud
left a comment
There was a problem hiding this comment.
This looks ok to me.
Can we document what was the problem with the previous build system in the PR please?
I wanted to try and put as much things into make, but it doesn't seem possible because we don't know the command line arguments. Makes you want to add some metadata to your ASL test files...
I did not check the .tex files.
1e026c0 to
461d0ba
Compare
461d0ba to
ac9b3ce
Compare
3 participants
Previously, console output was spliced directly into
.texfiles by manually runningdoclint.py -cm. Changes to referenced ASL tests could therefore leave the documented output stale. This change generates console output automatically as part of the document build.Replace inline generated console output with
\RenderConsoleFor:\ASLListingspellchecking.aslref. Previous attempts to build aslref defaulted to a path that might not exist.asllib/doc/Makefilenow buildsaslrefautomatically.