improved HTML rendering of the ASL Reference with MathJax - #1906
Draft
Roman-Manevich wants to merge 1 commit into
Draft
improved HTML rendering of the ASL Reference with MathJax#1906Roman-Manevich wants to merge 1 commit into
Roman-Manevich wants to merge 1 commit into
Conversation
Collaborator
|
The HTML that renders correctly does indeed look much improved. However, a very brief inspection shows various bugs - e.g. in screenshots attached, missing quotes around the tokens "(" and ")", and bad rendering of |
hrutvik
reviewed
Jul 9, 2026
Collaborator
There was a problem hiding this comment.
Do we really want to check in all of this content?
Comment on lines
+41
to
+43
| python3 $(HEVEA_DIR)/generate_mathjax_config.py $(MATHJAX_CONFIG_JS) HTML/ASL.html | ||
| cd HTML && hacha ASL.html | ||
| python3 $(HEVEA_DIR)/generate_mathjax_config.py $(MATHJAX_CONFIG_JS) HTML/ASL[0-9][0-9][0-9].html |
Collaborator
There was a problem hiding this comment.
Why do we need to run the Python script twice? Could we not run it on the split-up output only?
Collaborator
There was a problem hiding this comment.
This is quite difficult to review, and I worry about our ability to maintain and stand behind it. Is all of it necessary? Can it be minimised somehow?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved the HTML version of the ASL Reference via MathJax.
This PR is AI-assisted.