Repository navigation
feat(player): make desktop playback controls resizable - #557
Open
michaelmoskie wants to merge 3 commits into
Open
michaelmoskie wants to merge 3 commits into
michaelmoskie wants to merge 3 commits into
Conversation
Add lockable pointer and keyboard dividers to the bottom player bar. Scale the controls within usable bounds and remember the layout in the browser.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new adjustable layout for the mini player component, allowing users to resize and customize the player sections when the player is wide. The changes include a new composable for managing layout state, a new divider component for resizing, UI updates to support adjustable sections, and localization updates for new controls.
Adjustable Mini Player Layout:
useMiniPlayerLayoutto manage the adjustable grid layout, handle resize logic, and persist user preferences. This enables users to unlock, drag, and reset the layout of the mini player sections. (frontend/src/components/shell/miniPlayerLayout.js[1] [2]PlayerDivider) between them. New controls allow unlocking/locking and resetting the layout. (frontend/src/components/shell/MiniPlayer.vue[1] [2] [3] [4] [5] [6] [7] [8] [9]frontend/src/components/shell/MiniPlayer.vuefrontend/src/components/shell/MiniPlayer.vueR416-R483)UI and Icon Enhancements:
frontend/src/components/ui/icons.jsfrontend/src/components/ui/icons.jsR124)frontend/src/components/shell/PlayerDivider.vuefrontend/src/components/shell/PlayerDivider.vueR1-R25)Localization:
frontend/src/i18n/locales/en.js[1]frontend/src/i18n/locales/bg.js[2]frontend/src/i18n/locales/de.js[3]frontend/src/i18n/locales/el.js[4]frontend/src/i18n/locales/es.js[5]frontend/src/i18n/locales/fr.js[6]frontend/src/i18n/locales/hu.js[7]Add lockable pointer and keyboard dividers to the bottom player bar. Scale the controls within usable bounds and remember the layout in the browser.