Skip to content

Introduce query executor strategy, enabling #165 - #174

Merged
helun merged 3 commits into
helun:masterfrom
YannRobert:IntroduceQueryExecutorStrategy
Apr 22, 2014
Merged

Introduce query executor strategy, enabling #165#174
helun merged 3 commits into
helun:masterfrom
YannRobert:IntroduceQueryExecutorStrategy

Conversation

@YannRobert

Copy link
Copy Markdown
Collaborator

This is a refactoring.
This change has no impact on runtime.

This permits to easily change the implementation of StdCouchDbConnector.executeQuery(ViewQuery, ResponseCallback)
It should therefore enable #165 to be fixed in a non intrusive way.

@YannRobert

Copy link
Copy Markdown
Collaborator Author

TravisCI failed on unit test that has nothing to do with the change

@helun

helun commented Apr 22, 2014

Copy link
Copy Markdown
Owner

LegacyQueryExecutor? How about DefaultQueryExecutor? Names such as LegacyX makes the codebase feel rotten and cumbersome...

@YannRobert

Copy link
Copy Markdown
Collaborator Author

I agree that Legacy sounds bad.
I was on Default... at the beginning, but had the feeling is would encourage new users to use it whatever new or better alternative may come up in the next ... years.
Any other option you can think of ?

@helun

helun commented Apr 22, 2014

Copy link
Copy Markdown
Owner

It is the default, is it not? And it will always work, although not optimal costwise in the cloudant case.
We could either create a CloudantConnectorFactory that creates a connector configured for cloudant and/or capture this in the docs.

@YannRobert

Copy link
Copy Markdown
Collaborator Author

Renamed it to DefaultQueryExecutor.

…plementation of StdCouchDbConnector.executeQuery(ViewQuery, ResponseCallback) to new class DefaultQueryExecutor that is used by default. This should greatly improve the ability to change the default behavior in a non intrusive way
…ntations can get the URI object and eventually change it before turning it into a String
@YannRobert

Copy link
Copy Markdown
Collaborator Author

rebased from master + squashed class renaming and comments fix

helun pushed a commit that referenced this pull request Apr 22, 2014
Introduce query executor strategy, enabling #165
@helun
helun merged commit bb3b3f2 into helun:master Apr 22, 2014
@ceefour

ceefour commented Apr 22, 2014

Copy link
Copy Markdown
Contributor

@helun @YannRobert Thanks :) Now I can wait for 1.4.2 release :)

@ceefour

ceefour commented Sep 18, 2014

Copy link
Copy Markdown
Contributor

@YannRobert @helun 1.4.2 changes are not sufficient to implement my own QueryExecutor properly.

Please review #192 for the additional changes required.

@YannRobert
YannRobert deleted the IntroduceQueryExecutorStrategy branch February 10, 2015 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants