Repository navigation
fix(cli): fail lint when rule violations are reported - #326
Open
bandstacker wants to merge 1 commit into
Open
bandstacker wants to merge 1 commit into
bandstacker wants to merge 1 commit into
Conversation
lint printed violations and still returned success, so CI could not use it as a gate. Error-level violations now fail the command.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buffrs lintexit non-zero when it reports error-level rule violations.--deny warningsis passed.--allow warningskeeps that default.Why
lintprinted violations and then returned success, so CI could not use the command as a gate. Violations go to stderr, which also makes a stdout grep miss them.Fixes #322
Test plan
cargo test --test e2e cmd::lintcargo test --lib validation::violation::testscargo fmt --all -- --checkcargo clippy --all-targets --workspace -- -D warnings -D clippy::all