Skip to content

Phase 3 polish + 13MSG E2E test handoff to DCT - #26

Merged
terchris merged 2 commits into
mainfrom
feature/p3-polish-and-dct-test-handoff
Apr 9, 2026
Merged

Phase 3 polish + 13MSG E2E test handoff to DCT#26
terchris merged 2 commits into
mainfrom
feature/p3-polish-and-dct-test-handoff

Conversation

@terchris

@terchris terchris commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

Ships Phase 3 (cosmetic polish) of the template docs investigation, plus a handoff message (13MSG) telling DCT they're unblocked for their E2E test.

Phase 3 — Polish

  • A1: Created postgresql-demo-logo.svg (PostgreSQL blue + "PG")
  • A5: Already done in Phase 2 — JSON example uses Xa7mP9... placeholder text
  • B10: Created python-basic-webserver-database-logo.svg (Python blue with DB badge); template-info.yaml updated
  • C3: Tag scheme documented in naming-conventions.md with categories, examples, and common mistakes. Fixed three inconsistencies:
    • golang-basic-webserver: dropped redundant go, kept golang
    • typescript-basic-webserver: dropped nodejs (runtime is implied by language)
    • python-basic-webserver-database: dropped misleading demo tag (it's a real-use template, not a demo)
  • C4: Created webserver-database-logo.svg category logo (navy + WS+DB); template-categories.yaml updated

13MSG — TMP → DCT handoff

DCT's Phase 3 of PLAN-p1-dct-shim.md was an E2E test in a fresh devcontainer with TMP's rewritten templates. Blocked on TMP's README rewrites — which are now shipped. 13MSG explicitly hands off:

  • The rewritten READMEs are the test plan (no separate test script needed)
  • The 7-step canonical workflow in python-basic-webserver-database README
  • Pass criteria: /tasks returns the 3 seeded rows
  • Optional second test: postgresql-demo
  • Format for the response (14MSG: DCT → TMP: ...)

Phase status after this PR

Phase Status
Phase 1 — Foundation Shipped (PR #25 + DCT v1.7.34 + UIS PR #121)
Phase 2 — Improvements Deferred (intentional)
Phase 3 — Polish Shipped in this PR
Future Out of scope

Test plan

  • validate-metadata.sh passes
  • validate-docs.sh passes (0 errors)
  • npm run build passes in devcontainer
  • All template-info.yaml files have consistent tags
  • All three new logos are SVG, follow the existing style
  • CI pipeline green after merge
  • DCT confirms E2E test passes (separate from this PR)

🤖 Generated with Claude Code

terchris and others added 2 commits April 9, 2026 13:30
Per DCT's 12MSG response: DCT does not have JSON merge functionality
and won't add it. The README documentation pattern is the canonical
answer for VS Code workspace settings in templates.

readme-structure.md: new "VS Code settings pattern" section
- Rule: templates must not ship .vscode/settings.json or
  .vscode/extensions.json files (would risk overwriting user config)
- Pattern: document the setting in the README under a "VS Code tip"
  section, with the literal one-line addition the user pastes into
  their workspace settings
- Four rules: symptom sentence, fix sentence, copy-pasteable JSON,
  "don't replace the file" reminder
- Universally-needed settings belong in DCT's base devcontainer image,
  not template files

Investigation: marked 11MSG and 12MSG as resolved (done by DCT and TMP).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Phase 3 (cosmetic) — done:

- A1: Created postgresql-demo-logo.svg (PostgreSQL blue + "PG")
- A5: Already done in Phase 2 — JSON example uses Xa7mP9... placeholder
- B10: Created python-basic-webserver-database-logo.svg (Python blue
  with DB badge); template-info.yaml updated to reference it
- C3: Tag scheme documented in naming-conventions.md with categories,
  examples, and common mistakes. Fixed three inconsistencies:
  - golang-basic-webserver: dropped redundant `go`, kept `golang`
  - typescript-basic-webserver: dropped `nodejs` (runtime is implied
    by language)
  - python-basic-webserver-database: dropped misleading `demo` tag
    (it's a real-use template, not a demo)
- C4: Created webserver-database-logo.svg category logo (navy + WS+DB);
  templates/template-categories.yaml updated to reference it

Phase 1 + Phase 3 of the investigation are now both shipped. Phase 2
remains deferred (quality-of-life improvements awaiting real feedback).

Investigation: 13MSG added — TMP → DCT handoff for the E2E test that
DCT had as their last Phase 1 work item (Phase 3 of PLAN-p1-dct-shim.md,
blocked on TMP's README rewrites). The rewritten README is now the test
plan — DCT just follows the canonical 7-step workflow literally and
confirms /tasks returns the seeded rows.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@terchris
terchris merged commit afa0a63 into main Apr 9, 2026
@terchris
terchris deleted the feature/p3-polish-and-dct-test-handoff branch April 9, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant