mbo/hash/measurements: README-table sizes from the data (single source of truth) - #249
Merged
Conversation
…/127/128) #245 completed the C++ kReadmeSizes (5, 38, 127/128) but not the Python _README_SIZES mirror that filters the README tables, so the published tables would silently omit those four sizes. Bring the mirror back in sync.
…source of truth) Delete the Python _README_SIZES list. _throughput_table now reads its sizes from the data's own buckets (like _latency_table already did), so there is no second size list to drift from the C++ kReadmeSizes - which is the sole source of truth. run_measurements runs a FAST sweep (buckets == kReadmeSizes) for the README tables and the FULL sweep for the ns-vs-length chart, bundling both. This closes the drift that let #245's C++ size additions (5/38/127/128) silently miss the tables.
Fab-Cat
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the size-drift class of bug: #245 added
5/38/127/128to the C++kReadmeSizesbut not the duplicate Python_README_SIZES, so the tables would have silently dropped four sizes.Rather than re-sync two lists, this removes the duplication:
_throughput_tablereads its sizes from the data's own buckets (as_latency_tablealready did), and the Python_README_SIZESlist is deleted. The C++kReadmeSizesis now the sole source of truth -run_measurementsrenders the README tables from a FAST sweep (whose buckets arekReadmeSizes) and the chart from the FULL sweep, bundling both. Nothing to drift.Verified: a fast run's data buckets ==
kReadmeSizesexactly (22 sizes), and the rendered table has all 22 rows read from the data.