Repository navigation
docs: README demo from a real container run, dry-run and preflight notes - #2
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README audit. Discrepancies fixed:
--profile minimalrun twice in a freshubuntu:24.04container (first run changes 3 steps, second changes none, one managed block in.bashrc), plus the text and a one-line Docker command to reproduce it.--dry-runaccounting was undocumented: verify is skipped and would-apply steps are counted as "skipped" in the summary.curlnorpingexists, as on a fresh container. Added to Limitations.go install, which checks the Go checksum database. Reworded to say exactly that.Verified:
bats tests/-> 69 ok (macOS) anddocker run --rm -v "$PWD:/w" -w /w bats/bats:latest tests/-> 69 okshellcheck bootstrap.sh lib/*.sh steps/*.shclean;shfmt -d .(v3.9.0) clean./bootstrap.sh --help,--list-steps,--list-profilesmatch the README; profile contents match the table./bootstrap.sh --profile web --dry-runwith scratch state/log on macOS: exit 0, no state file createdNot run: real runs on macOS/desktop Linux, dnf/pacman/brew installs (stubbed tests only).