Clone missing production repos in system update, run it on -f, standalone cleanup script#32
Open
hello-bharadwaj wants to merge 1 commit into
Open
Clone missing production repos in system update, run it on -f, standalone cleanup script#32hello-bharadwaj wants to merge 1 commit into
hello-bharadwaj wants to merge 1 commit into
Conversation
…pdate on -f, make cleanup script standalone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
These changes make the
-f(fresh Ubuntu / factory install) path end in the same state as the-g(golden image) path, so a robot installed either way can proceed into the production test flow (FAB bench QC and onward) fromstretch_production_tools_ii.factory/24.04/stretch_system_update.sh~/reposif it doesn't exist instead of exiting with an error.stretch_firmware_ii,stretch_production_tools_ii,stretch_fleet_ii,stretch_production_data_ii,stretch4_pyhesai_wrapper) that aren't already present, then checks out the right branch (developfor firmware, main/master for the rest) and pulls. A failed clone (e.g. missing credentials) skips that repo instead of aborting the whole update.hello-robot-stretch4-body,-urdf,-flying-gripper,-tray.stretch_new_robot_install.sh-ffactory install now also runsstretch_system_update.sh(after dev tools), so fresh installs get~/repospopulated with the production repos just like-ggolden image setups do. Previously a fresh install ended with no~/reposat all, and the production tools updater would hard-fail on it.factory/24.04/stretch_cleanup_robot.shutils/cleanup_production_data.shfromstretch_production_tools_ii(adds Antigravity uninstall, system trash clearing, shell history/~/Videosclearing, and the final pip package refresh).section/ok/warn/fail, a simplifiedrun_stepwith timeout,print_summary) so it runs standalone withoutproduction_logger.sh— no log files or progress bar, same steps and behavior otherwise.Notes for reviewers
-for-g, the production tools Python package still needs its editable install via~/repos/stretch_production_tools_ii/utils/stretch_system_update.sh(Production Guide Section C) beforeFAB_manager.pycan run — unchanged by this PR.stretch_system_update.shhas noset -e, so pull/pip failures don't fail the script; left as-is for now.