Repository navigation
Conversation
Member
|
Dropping Is the idea to use this for something like Zellij? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Terminal multiplexers need both physical key identity and generated text to re-encode input faithfully. The current parser replaces the canonical key with the shifted key, clears Shift, and drops base-layout and associated-text fields, which makes combinations such as Shift+1 impossible to forward correctly.
Validation
cargo testcargo clippy --all-targets -- -D warningscargo check --target x86_64-pc-windows-gnu --features windows-legacyKeyEventis no longerCopybecause associated text is variable-length; this is an intentional API change.