Repository navigation
Theme scope cleanup - #16381
Open
smartinellimarco wants to merge 5 commits into
Open
Theme scope cleanup#16381smartinellimarco wants to merge 5 commits into
smartinellimarco wants to merge 5 commits into
Conversation
…and ui.cursorcolumn
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up theme scopes that drifted between the code and the book.
The active tab falls back to
ui.statuslineand the background toui.statusline.inactive, andui.statusline.activeis no longer read, as suggested in add ui.statusline.active documentation #9567 (comment).github_darkandgithub_lightmove theirui.statusline.activetoui.bufferline.activeso they render the same.Removes
markup.normal,markup.normal.{completion,hover,raw},markup.heading.{completion,hover,raw}andmarkup.raw.inline.{completion,hover}from the book and bundled themes.The popup namespacing was dropped in Allow separate styles for markup headings #1618 (comment) and
markup.normalin e7f5ec5, but the book and themes kept them.Documents
ui.gutter.virtual,ui.gutter.selected.virtualandui.cursorcolumn, which the code reads but the book didn't list.Themes that set no
ui.bufferline*scope now draw the bufferline background withui.statusline.inactive.Refs #9239, #3649