Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16366.
Since d27856b,
textobject_treesitteronly looks at the innermost injection layer under the cursor.If that layer's language has no textobject query, or no matching capture, the selection does not change. It should fall back to the enclosing language.
The most visible case is comments: in Rust (and any language that injects
comment),micandmacdo nothing when the cursor is inside a comment, because thecommentlanguage has notextobjects.scm.Doc comments are affected the same way through the
markdown-rustdocinjection.The fix iterates through the layers at the cursor from inside to outside and uses the first one that gives a node containing the cursor.
Added a regression test that selects
comment.insidewith the cursor inside a Rust line comment.Related: #16335 fixes the same problem for
goto_treesitter_object(]c/[c, see #16333). The fixes are independent, though.