Repository navigation
Conversation
Dronakurl
marked this pull request as ready for review
June 9, 2026 20:32
Dronakurl
marked this pull request as draft
June 10, 2026 05:07
Dronakurl
force-pushed
the
multi-set-option
branch
2 times, most recently
from
June 10, 2026 18:03
3f2d0f2 to
b005d23
Compare
Dronakurl
marked this pull request as ready for review
June 10, 2026 19:13
Dronakurl
force-pushed
the
multi-set-option
branch
2 times, most recently
from
June 19, 2026 01:36
1cde260 to
734f686
Compare
|
|
Dronakurl
force-pushed
the
multi-set-option
branch
2 times, most recently
from
June 29, 2026 23:55
c877796 to
4c48a61
Compare
Dronakurl
force-pushed
the
multi-set-option
branch
2 times, most recently
from
July 8, 2026 19:32
d2adb27 to
ae16a8b
Compare
Dronakurl
force-pushed
the
multi-set-option
branch
from
September 5, 2026 10:43
ae16a8b to
58e1a99
Compare
> This PR was prepared with a coding agent (Mistral Vibe) Adds ConfigEvent::UpdateField variant to allow updating individual config fields instead of replacing the entire config. This fixes the issue where multiple :set-option commands in a keybinding sequence would only apply the last option, as each command was reading the same initial config state and sending full config replacements. Modified set_option and toggle_option commands to use UpdateField, and added handling in application.rs. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
Adds 4 integration tests to verify that multiple :set and :toggle commands in a keybinding sequence work correctly: - test_set_config_single - test_set_config_multi - test_toggle_config_single - test_toggle_config_multi This ensures the fix for issue helix-editor#13187 works as expected. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
Dronakurl
force-pushed
the
multi-set-option
branch
from
October 10, 2026 17:55
58e1a99 to
61ac4ff
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When using a keybinding with multiple
:set-optioncommands in a sequence, only the last option takes effect. For example:Only
inline-diagnostics.cursor-linewould be set, whileend-of-line-diagnosticswould retain its previous value.The issue occurred because all commands in a sequence would read the same initial config state (before any updates were applied), create full config replacements, and send them. The last event would overwrite all previous changes.
Solution
Adds
ConfigEvent::UpdateFieldvariant for incremental config field updates. Commands now send individual field updates (key path + value) which the application applies sequentially, allowing them to compose correctly.Related