Skip to content

fix(ui/prompt): cache history suggestion to avoid repeated reads - #15710

Open
Dronakurl wants to merge 1 commit into
helix-editor:masterfrom
Dronakurl:fix-15497-cached-suggestion
Open

Dronakurl wants to merge 1 commit into
helix-editor:masterfrom
Dronakurl:fix-15497-cached-suggestion

Conversation

@Dronakurl

Copy link
Copy Markdown

Fixes #15497. Caches the first history completion to avoid repeated expensive reads from clipboard registers on every frame.

@Dronakurl
Dronakurl force-pushed the fix-15497-cached-suggestion branch 2 times, most recently from a9d4a85 to 2fda572 Compare June 2, 2026 19:22
@Dronakurl
Dronakurl force-pushed the fix-15497-cached-suggestion branch 4 times, most recently from 3b4df50 to e26633d Compare June 13, 2026 18:09
@Dronakurl
Dronakurl force-pushed the fix-15497-cached-suggestion branch 2 times, most recently from 40f598f to ce6bb45 Compare June 18, 2026 19:24
@Dronakurl
Dronakurl force-pushed the fix-15497-cached-suggestion branch 2 times, most recently from 5d22c5b to 227500f Compare June 29, 2026 23:56
@Dronakurl
Dronakurl force-pushed the fix-15497-cached-suggestion branch 2 times, most recently from c181ea6 to 04a28b8 Compare July 8, 2026 19:32
@Dronakurl
Dronakurl force-pushed the fix-15497-cached-suggestion branch from 04a28b8 to 3d1344e Compare September 5, 2026 10:44
Cache the first history completion in the Prompt struct to avoid
repeated expensive reads from clipboard registers (* and +) on
every render frame. This fixes glitching when using these registers
in search mode (issue helix-editor#15497).
@Dronakurl
Dronakurl force-pushed the fix-15497-cached-suggestion branch from 3d1344e to 8b63e9a Compare October 10, 2026 17:54

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Helix glitches when searching in a file

1 participant