Repository navigation
Fix incorrect @param null docblock on verta() helper - #191
Merged
hekmatinasser merged 1 commit intoOct 25, 2026
Merged
hekmatinasser merged 1 commit into
hekmatinasser merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
verta()helper insrc/helpers.phpdocuments both parameters as accepting onlynull:This doesn't match reality — the function just forwards to new Verta($datetime, $timezone), and Verta extends Jalali, whose constructor (and its own resolve() docblock) accepts Jalali|DateTime|string|int|null for the datetime and DateTimeZone|string|null for the timezone. Calling verta($someDateString) or verta($carbonInstance) works fine at runtime, but the incorrect docblock makes static analysis tools (PHPStan/Larastan) flag every call site that passes an actual datetime value as a type error, even though the code is correct.