Skip to content

Improve shareText and title - #439

Open
InfoLibre wants to merge 32 commits into
heiseonline:developfrom
InfoLibre:develop
Open

Improve shareText and title#439
InfoLibre wants to merge 32 commits into
heiseonline:developfrom
InfoLibre:develop

Conversation

@InfoLibre

Copy link
Copy Markdown
Contributor

InfoLibre added 30 commits May 12, 2024 12:20
One don't share but plan on Buffer.
Flattr doesn't exists anymore.
Flattr doesn't exist anymore.
Replace Fediverse by Mastodon
Replace Fediverse by Mastodon
Replace Fediverse by Mastodon.
Improve title.
2) Improve title.
StumbleUpon doesn't exist anymore.
StumbleUpon doesn't exist anymore.
Tencent Weibo (http://t.qq.com) doesn't exist anymore.
Weibo (https://weibo.com) still exists but it isn't the same company?
Tencent Weibo doesn't exist anymore.
@richard67

Copy link
Copy Markdown
Contributor

This change here makes sense when you have a title like e.g. "Share this page" and then show the sharing icons close to that.

On the other hand, if you don't have such a title or label and have also buttons with social media icons to go to the home page in the particular social media, then it would be confusing, and the current sharing texts and titles are more clear.

So maybe it would be good to have a configuration option like e.g. "use_brand_name" or so, to toggle between the current behaviour and the one introduced by this PR?

@InfoLibre

InfoLibre commented May 14, 2025

Copy link
Copy Markdown
Contributor Author

People know that these icons are for sharing and and a title near these buttons usually indicates this. But I agree, a configuration option to choose between use_brand_name and current behavior is a good idea. It's not always a brand, it can be different for some icons: email, RSS, print. I think it's more about the communication medium.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants