event: align English molad memo format with @hebcal/core - #33
Merged
Conversation
Render the English molad announcement as "Molad <Month>: <FullWeekday>, <time>[ and <N> chalakim]" to match @hebcal/core, replacing the old "...: <Thu>, <M> minutes and <N> chalakim after <H>:00" form. The wall-clock time is location dependent: 12-hour with an am/pm suffix in 12-hour countries (US, CA, ...) and 24-hour elsewhere, so NewMoladEvent now takes a country code. The molad calculation itself is location independent. Chalakim are omitted when zero in both the English and Hebrew renderings, matching core. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CmSgHoAWaHsVFU7bLLUXzJ
|
mjradwin
added a commit
to hebcal/hebcal
that referenced
this pull request
Jul 8, 2026
* event: add GetCategories to CalEvent in hebcal/hebcal-go#31 * hebcal: round tzeit times, link candle to parsha, add MevarchimChodeshEvent in hebcal/hebcal-go#32 * event: align English molad memo format with @hebcal/core in hebcal/hebcal-go#33 * zmanim: compute sofZmanMGA from sea-level sunrise/sunset in hebcal/hebcal-go#30 * Add zmanim for the JSON API + IsAssurBemlacha in hebcal/hebcal-go#29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render the English molad announcement as
"Molad <Month>: <FullWeekday>, <time>[ and <N> chalakim]" to match @hebcal/core, replacing the old
"...: <Thu>, <M> minutes and <N> chalakim after <H>:00" form.
The wall-clock time is location dependent: 12-hour with an am/pm suffix in 12-hour countries (US, CA, ...) and 24-hour elsewhere, so NewMoladEvent now takes a country code. The molad calculation itself is location independent. Chalakim are omitted when zero in both the English and Hebrew renderings, matching core.