Apply smart apostrophe formatting to Hebrew month titles - #25
Merged
Conversation
drawHebMonthTitle built the mm=1/mm=2 headline directly from hebMonthName() without running it through jsutil.SmartApostrophe, so "Sh'vat 5787" used a typewriter apostrophe there while the same month name rendered smart everywhere else (event subjects, the mm=0 subtitle via altDateBrief). Wrap it the same way render.go's other two call sites already do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply smart apostrophe formatting to Hebrew month names in PDF calendar headers to ensure consistent typographic presentation.
Changes
hebMonthName()result withjsutil.SmartApostrophe()in the Hebrew month title rendering to normalize apostrophe characters in month namesDetails
This change ensures that Hebrew month names displayed in PDF calendar headers use proper typographic apostrophes rather than straight quotes, maintaining consistency with the rest of the document's text formatting. The
SmartApostropheutility function handles the character normalization transparently.https://claude.ai/code/session_01DnutVc7z8QrQ2MSJGFsXWG