[MEDIUM] Pin workflow actions to immutable commits - #263
Open
OskarEichler wants to merge 1 commit into
Open
OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security impact
The release job grants
contents: writeandid-token: write. Resolving an action through a mutable tag lets a compromised or retargeted tag execute with those permissions and affect package publishing. Immutable commit references make the reviewed action code the code that runs.The read-only CI jobs are pinned at the same boundary to prevent unreviewed action changes from entering those jobs.
Verification
rbenv exec bundle exec rake: 116 runs, 291 assertions, 0 failuresrbenv exec bundle exec rubocop: 22 files, no offensesrbenv exec bundle exec rake build: builtresponders-3.2.1.gemuses:references use 40-character commit SHAsgit diff --checkLimitations
The RubyGems trusted-publishing/OIDC release itself was not exercised locally; this change only replaces action references and preserves workflow inputs and permissions.
Breaking changes
None. Runtime code, dependencies, workflow behavior, and selected action versions are unchanged.