Repository navigation
Add a godebug input so a caller can set GODEBUG for go test - #1
Merged
Merged
Conversation
leakcheck's leak detection (upstream gotrace) panics unless GODEBUG=tracebackancestors=N is set, //go:debug rejects runtime settings such as this one, and upstream's own CI set the variable in the workflow env. A called workflow does not inherit the caller's env, so the reusable workflow takes the value as an input and applies it to the go test step only. Found while writing the satellites' callers (wand #38).
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two of the four snapshot satellites of wand #38,
leakcheck(upstream gotrace v0.6.0) andeventbus(goob v0.4.0, whose tests use leakcheck), refuse to run their suites withoutGODEBUG=tracebackancestors=N:IgnoreNonChildrenpanics otherwise, by upstream design. Upstream's CI set the variable in the workflowenv.//go:debug tracebackancestors=100is rejected by the toolchain (unknown //go:debug setting); the same holds for thegodebugdirective ingo.mod.env.What
godebug(string, default empty), applied asGODEBUGon thego teststep of everytestcell. Empty leaves the runtime's defaults.No behaviour change for callers that do not pass the input. The smoke run exercises the unchanged path.