prometheus: Fix metric count plural forms - #1240
Open
illume wants to merge 1 commit into
Open
Conversation
illume
requested review from
ashu8912,
joaquimrocha,
skoeva,
sniok,
vyncent-t and
yolossn
as code owners
August 24, 2026 20:50
Signed-off-by: René Dudfield <renedudfield@microsoft.com>
illume
force-pushed
the
fix-prometheus-metrics-plurals
branch
from
August 24, 2026 20:59
12972e4 to
0aaf470
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the KEDA scaler metric-count English defaults so count 1 uses the singular form and other counts use the plural form.
The explicit plural defaults keep
npm run i18ngeneration stable and correct the committed English locale.Validation:
npm run tscnpm run lintnpm test(36 passed, 1 skipped)npm run i18npreserves the corrected_oneand_othervalues